More details php version information in diagnose #3609
Conversation
There was a problem hiding this comment.
This shows me we need to do a bit of a refactoring.
Current state: ComposerPhpVersionFactory either reads phpVersion from phpstan.neon (if it has min+max), or from composer.json. And ConstantResolver uses ComposerPhpVersionFactory for this logic.
Wanted state: ComposerPhpVersionFactory only reads PHP version from composer.json, as its name says. And then ConstantResolver decides if it should read phpVersion from phpstan.neon with min/max provided. And if it's not there then it should read it from ComposerPhpVersionFactory.
Feel free to do this in a separate PR before this one. Thanks.
|
Looking at ComposerPhpVersionFactory usages, I found a bug: VersionCompareFunctionDynamicReturnTypeExtension only looks at composer version, not phpVersion.min+max version. |
I will send a separate PR |
|
Awesome, now it makes sense to me :) |
| @@ -2108,6 +2108,7 @@ services: | |||
| arguments: | |||
| composerAutoloaderProjectPaths: %composerAutoloaderProjectPaths% | |||
| allConfigFiles: %allConfigFiles% | |||
| configPhpVersion: %phpVersion% | |||
| autowired: false | |||
|
|
|||
| # Error formatters | |||
as requested in #3584 (comment)